Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve inline resilience #3245

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Conversation

jojo2357
Copy link
Contributor

Should work better outside of IJ

Fix #3244

Inlining a command will no longer piggyback off of Java's inline settings, and so will need to be specified every time, but it will work in any ide regardless of the status of the java plugin

Should work better outside of IJ
@jojo2357
Copy link
Contributor Author

All tests passed locally

@PHPirates PHPirates changed the title Improve inline resillience Improve inline resilience Sep 13, 2023
Copy link
Collaborator

@PHPirates PHPirates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Yes it's a bit unfortunate that we would have to save the setting ourselves, but this is fine for now.

I know I should fix the github action, it's taking too much resources I think (github doesn't publish how much you're allowed to use)

@PHPirates PHPirates merged commit 68f3900 into Hannah-Sten:master Sep 13, 2023
@PHPirates PHPirates added this to the Next milestone Sep 13, 2023
@jojo2357 jojo2357 deleted the inline-fix branch September 13, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

java.lang.NoClassDefFoundError: com/intellij/refactoring/JavaRefactoringSettings
2 participants