Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D3D12SDKVersion in D3D12Core is still 610 #2240

Closed
RalfKornmannEnvision opened this issue Dec 3, 2024 · 2 comments · Fixed by #2242
Closed

D3D12SDKVersion in D3D12Core is still 610 #2240

RalfKornmannEnvision opened this issue Dec 3, 2024 · 2 comments · Fixed by #2242

Comments

@RalfKornmannEnvision
Copy link

The current stable version of the Agility SDK reports 614.

We (Pioneers of Pagonia) check if we get the version (or newer) that we are requesting. To ensure that the game doesn't become unplayable after the patch with the current Agility SDK has been rolled out I needed to check for vkd3d and relex the SDK check to 610.

Preferable I'd like to avoid these kind of hacks.

@HansKristian-Work
Copy link
Owner

HansKristian-Work commented Dec 3, 2024

Merged an update, but out of curiosity, what is the reason the game needs to check that value to begin with? From a Windows point of view, the runtime version will always be greater or equal to the one application ships, so an application should never have to check that value.

@RalfKornmannEnvision
Copy link
Author

If you have a old Windows you can create a D3D12 device without the runtime loading the D3D12Core.dll at all. Therefore we need to check if it is loaded anyways. As we already have the module handle we although ensure that the version match. It's mostly part of better safe than sorry. Players sometimes running strange tools that manipulate system dlls and we got the blame for crashes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants