Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

about uniform loss #40

Open
rsy6318 opened this issue Jun 6, 2022 · 2 comments
Open

about uniform loss #40

rsy6318 opened this issue Jun 6, 2022 · 2 comments

Comments

@rsy6318
Copy link

rsy6318 commented Jun 6, 2022

In loss.py line 34, I think 'pcd' does not need to transpose because the input of fps function's size is (B,N,C).
@Taylor-Swift1
Copy link

Yes, I agree with you. Actually, it will produce new problem using transpose. After FPS, the indexes of sampling are almost 0. So, it can't evaluate the uniformity loss.

@Taylor-Swift1
Copy link

This problem has been solved. My pull request has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rsy6318 @Taylor-Swift1