Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG border-radius issue #52

Closed
ghost opened this issue May 16, 2022 · 3 comments
Closed

SVG border-radius issue #52

ghost opened this issue May 16, 2022 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@ghost
Copy link

ghost commented May 16, 2022

Hey I noticed the flags have been updated to use <style> now for border-radius. Specifically the value 50% is leading to errors if user is using for example react-native-svg library's component for rendering the svg, since it is trying to pass the borderRadius as a string instead of a number.

Not really sure if this is something that could or should be fixed here or in the react-native-svg lib, but something to be aware of.

@HatScripts HatScripts added bug Something isn't working good first issue Good for newcomers labels May 16, 2022
@HatScripts
Copy link
Owner

Hey, thanks for the heads-up. This indeed sounds like it is a bug with react-native-svg, so maybe it would be best to create an issue on their repo.

@ghost ghost closed this as completed May 16, 2022
@gsgou
Copy link

gsgou commented Aug 18, 2022

As mentioned also here: #53
is also an issue with other frameworks like skia used by flutter and xamarin.
Maybe makes sense to roll back on the mask used before.

@HatScripts
Copy link
Owner

As stated on #53, I've reverted back to using mask instead of border-radius as of v2.6.0 (07324c2), so this issue should now be fixed.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants