Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do you prevent secrets from being divulged in the workflow? #235

Closed
kaihendry opened this issue Nov 8, 2023 · 2 comments · Fixed by #236
Closed

How do you prevent secrets from being divulged in the workflow? #235

kaihendry opened this issue Nov 8, 2023 · 2 comments · Fixed by #236

Comments

@kaihendry
Copy link

For example you can see my secret "kensentme" is printed https://github.com/kaihendry/dotSecretTest/actions/runs/6796471305/job/18476619647

image

@HatsuneMiku3939
Copy link
Owner

Hi @kaihendry,

Thank you for your feature request. I'm happy to announce that I've just merged a pull request that implements the masks feature. This new feature is now automatically available in HatsuneMiku3939/direnv-action@v1. You can use the 'masks' option to pass a comma-separated list of environment variable names you wish to mask.

Please check out the detailed example of the 'masks' option in the README.md for more information.

If this new feature doesn't fully address your issue, feel free to fork the project or submit a PR. All contributions are welcome!

Best regards,

@HatsuneMiku3939

@kaihendry
Copy link
Author

kaihendry commented Nov 8, 2023

Thank you! I think philosophically I will only rely on direnv for local overrides. I'd rather not checkin .envrc. Instead I'll rely on something like https://github.com/aws-actions/aws-secretsmanager-get-secrets after thinking about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants