TLS Socket update #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Havvy tests should pass if you use the code in the PR for your mock of the net socket. |
|
@Havvy Any chance I could get this merged and/or would you be willing to make me a co-maintainer of the repo? I still use this library and also would like to explore implementing SASL support here, rather than in a wrapper library. |
|
For anyone interested, as this repo is no longer maintained, I've forked the project and added SASL and SSL support, published under the name |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Havvy - This now works with both normal and TLS Sockets. Requires a new publishing of the mock you created Havvy/mock-net-socket#1
The version that was published seemed to be newer than the code in that repo, so the PR contains my fixes but also the code from the published version.
resolves #25