Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlxFlicker and FlxTimer.pause()? #1553

Closed
MSGhero opened this issue Jul 1, 2015 · 10 comments
Closed

FlxFlicker and FlxTimer.pause()? #1553

MSGhero opened this issue Jul 1, 2015 · 10 comments

Comments

@MSGhero
Copy link
Member

MSGhero commented Jul 1, 2015

I know there's superissue #1087 in the air, but in the meantime, would it break anything if I added pause/resume methods to FlxTimer and by extension FlxFlicker? Are there other classes to add that to?

@Gama11
Copy link
Member

Gama11 commented Jul 1, 2015

Seems redundant, you can already pause and resume timers with active.

@Gama11 Gama11 closed this as completed Jul 1, 2015
@MSGhero
Copy link
Member Author

MSGhero commented Jul 1, 2015

For FlxTimer ok didn't know that, but since FlxFlickers aren't exposed, can there be a public static pause/resumeFlickersOf(obj)?

@Gama11
Copy link
Member

Gama11 commented Jul 1, 2015

Meh, not a fan of that API... then again I'm not a huge fan of FlxFlicker to begin with.

We could simply have the FlxSpriteUtil methods return the FlxFlicker instances?

@MSGhero
Copy link
Member Author

MSGhero commented Jul 1, 2015

That would be fine. Flickers feel like tweens which throws me off when static flicker() doesn't return the flicker object.

@sruloart
Copy link
Contributor

sruloart commented Jul 1, 2015

Also, if we're already at FlxFlicker it would've been nice if it could also have an option to color the sprite white (or any color mix) before the flickering begins (I'm thinking about old-school 8-bit enemy hit)...

@sruloart
Copy link
Contributor

sruloart commented Jul 1, 2015

On second thought, maybe this is better suited on another (FlxHit) class (somewhere at flixel-addons) as there are a lot of things (flickers, explosions, sprite positioning...) to consider when a sprite gets hit...

@Gama11
Copy link
Member

Gama11 commented Jul 1, 2015

Or maybe just let the programmer implement something for a change, instead of trying to provide everything in the engine. ;)

@sruloart
Copy link
Contributor

sruloart commented Jul 1, 2015

Never! :) btw, there's very little support for AI in Flixel...how about making a FlxBrain for sprites? ;D

@MSGhero
Copy link
Member Author

MSGhero commented Jul 1, 2015

Just looked, and FSU.flicker returns the FlxObject, so it'd probably be breaking to change that to return the flicker object.

@Gama11
Copy link
Member

Gama11 commented Jul 1, 2015

Yeah. I don't think that's a huge deal though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants