FlxTween: make start() public per docs #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 18, 2016 20:59
"FlxTween.PERSIST: stops when it finishes. Unlike ONESHOT, this type of tween stays attached to the core container when it finishes. This means you can keep a reference to this tween and call start() whenever you need it." From this, I believe it was originally intended that start() be public. - http://haxeflixel.com/documentation/flxtween/
"Field start has less visibility (public/private) than superclass one" since changing superclass start() to public.
"Field start has less visibility (public/private) than superclass one" since changing superclass start() to public.
|
Newlines get altered in almost every commit lol. Good catch 👍 |
|
Good point.. Looks like I made them private when fixing #951, but that's somewhat irrelevant now that tween pooling has been removed. |
Gama11
changed the title
Gama11
added a commit
that referenced
this pull request
Jan 18, 2016
FlxTween: make start() public per docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"FlxTween.PERSIST: stops when it finishes. Unlike ONESHOT, this type of tween stays attached to the core container when it finishes. This means you can keep a reference to this tween and call start() whenever you need it."
From this, I believe it was originally intended that start() be public.