Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto fullscreen on non-desktop platforms #1852

Open
buckle2000 opened this issue May 13, 2016 · 4 comments
Open

Auto fullscreen on non-desktop platforms #1852

buckle2000 opened this issue May 13, 2016 · 4 comments

Comments

@buckle2000
Copy link
Contributor

buckle2000 commented May 13, 2016

see here and here
I tested on flash using debug flash player and it worked (get fullscreen)
use FlxG.stage.allowsFullScreen to check fullscreen support rather than #if desktop?

@buckle2000 buckle2000 changed the title Why not auto fullscreen on non-desktop platforms auto fullscreen on non-desktop platforms May 13, 2016
@buckle2000 buckle2000 changed the title auto fullscreen on non-desktop platforms Auto fullscreen on non-desktop platforms May 13, 2016
@Gama11
Copy link
Member

Gama11 commented May 13, 2016

Hm.. good point! Not sure why this was restricted to desktop targets, maybe it causes issues on Flash if you don't have the required permissions in the browser? Also not sure if fullscreen does anything on mobile.

Why would the way in which the game dimensions are determined need to change?

@buckle2000
Copy link
Contributor Author

buckle2000 commented May 13, 2016

I mean this needs to modified to support auto resizing on fullscreen
So should I send a pull request?

@buckle2000
Copy link
Contributor Author

buckle2000 commented May 13, 2016

Also, is Lib.current.stage.window.display part of openfl legacy or it is not available in legacy?

@Gama11
Copy link
Member

Gama11 commented May 13, 2016

So should I send a pull request?

Sure.

Also, is Lib.current.stage.window.display part of openfl legacy or it is not available in legacy?

I don't think it's available in legacy, but just check.

Also, FlxG.scaleMode.scale, FlxG.scaleMode.deviceSize and FlxG.scaleMode.offset remain the same value after FlxG.fullscreen = true

Hm.. not sure why that would be the case, doesn't the resize event fire after a fullscreen toggle? Either way that seems like a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants