Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@:generic doesn't work with @:structInit #10550

Closed
ALANVF opened this issue Jan 10, 2022 · 3 comments
Closed

@:generic doesn't work with @:structInit #10550

ALANVF opened this issue Jan 10, 2022 · 3 comments

Comments

@ALANVF
Copy link
Contributor

ALANVF commented Jan 10, 2022

Example on try.haxe: https://try.haxe.org/#759D133E

@Simn
Copy link
Member

Simn commented Jan 15, 2022

Turns out we don't copy metadata to the generated classes at all, with the exception of @:keep. This probably causes all sorts of weird problems.

If anyone wants to help out: We should go through https://github.com/HaxeFoundation/haxe/blob/development/src-json/meta.json and check if there's any metadata that should not be on the generated class. The only one I can immediately think of is @:generic itself.

@Simn
Copy link
Member

Simn commented Jan 19, 2022

I've committed what I meant, using your list of metadata.

@ALANVF
Copy link
Contributor Author

ALANVF commented Jan 19, 2022

Fair enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants