Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #6825 #6847

Closed
ncannasse opened this issue Feb 13, 2018 · 6 comments
Closed

Revert #6825 #6847

ncannasse opened this issue Feb 13, 2018 · 6 comments

Comments

@ncannasse
Copy link
Member

I think #6825 does more harm than good. Having different typing for something as used as Array depending on the platform creates more issues, we want to avoid platform-specific typing as much as possible.

@RealyUniqueName please revert

@RealyUniqueName
Copy link
Member

Too bad )
This will be a big problem when/if we decide to implement null safety in the compiler.

@nadako
Copy link
Member

nadako commented Feb 13, 2018

This will be a big problem when/if we decide to implement null safety in the compiler.

I think null safety would require unspecifying out-of-bounds array access. It's already an issue for a lot of targets, they have to check bounds on each array access.

@RealyUniqueName
Copy link
Member

I don't think it's ok to deal with type holes and inconsistencies by unspecifying them )

Another Haxe issue is that we have too many things unspecified. That makes developers in our team face inconsistencies pretty often (I guess it's applicable to any Haxe user).
I'd like to avoid introducing even more unspecified things.

@nadako
Copy link
Member

nadako commented Feb 13, 2018

Another Haxe issue is that we have too many things unspecified.

that's the cost of overhead-less code generation, we're keeping fragile balance, not overspecifying too much to avoid run-time wrapper/checker code

@RealyUniqueName
Copy link
Member

RealyUniqueName commented Feb 13, 2018

Yes, I understand. But that is also one of the reasons I usually hear when devs are reasoning "why I left Haxe" )

@RealyUniqueName
Copy link
Member

Maybe having "unsafe" things for perforamnce-demanding code and "overspecified" things for cross-target consistency code would be a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants