Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[js.html] wrong return type for MediaElement.play() #6989

Closed
mockey opened this issue Apr 27, 2018 · 2 comments
Closed

[js.html] wrong return type for MediaElement.play() #6989

mockey opened this issue Apr 27, 2018 · 2 comments
Labels
platform-javascript Everything related to JS / JavaScript

Comments

@mockey
Copy link
Contributor

mockey commented Apr 27, 2018

The play() function of the HTMLMediaElement
https://api.haxe.org/js/html/MediaElement.html#play
returns a Promise instead of Void as of late.
This is important for dealing with autoplay blocking in Chrome 66, e.g.

Once again my question: Is it possible to make a PR for changes in the (generated) JS-API?

@Simn Simn added this to the Bugs milestone Apr 30, 2018
@Simn Simn added the platform-javascript Everything related to JS / JavaScript label Apr 30, 2018
@haxiomic
Copy link
Member

Hey @mockey, it's fixed in the newer WebIDLs – when js.html is re-generated this issue should be resolved. In the meantime you can create a file js/html/MediaElement.hx in your project and fill it with the newer externs: https://gist.github.com/haxiomic/511e2e801fc82b791a0d44ef1f99b161

@haxiomic
Copy link
Member

haxiomic commented Sep 9, 2018

Resolved in #7354

@haxiomic haxiomic closed this as completed Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform-javascript Everything related to JS / JavaScript
Projects
None yet
Development

No branches or pull requests

3 participants