Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration management #40

Closed
2 of 6 tasks
AndyRae opened this issue Jan 22, 2025 · 0 comments · Fixed by #83
Closed
2 of 6 tasks

Configuration management #40

AndyRae opened this issue Jan 22, 2025 · 0 comments · Fixed by #83
Assignees
Milestone

Comments

@AndyRae
Copy link
Member

AndyRae commented Jan 22, 2025

Is this the right issue type?

  • Yes, I'm planning work for this project team.

Summary

Currently, the configuration is managed directly through environment variables in settings.py + settings_database.py

It would be good to use a more structured configuration management system like Pydantic settings.

Benefits of this approach:

  • Type Validation: Pydantic automatically validates types and converts values
  • Default Values: Clearly defined defaults
  • Custom Validation: Using validators for complex rules
  • Documentation: Settings are self-documenting with type hints
  • IDE Support: Better autocomplete and type checking
  • Error Handling: Clear error messages when settings are invalid

Acceptance Criteria

  • Configuration is managed through a structure approached
  • No compatibility is changed with managing configuration

Tasks

  • Refactor to use a structured approach
  • Validate and write tests for loading configuration

Confirm creation

  • This issue is ready
@AndyRae AndyRae moved this to Ready in Hutch Backlog Jan 22, 2025
@AndyRae AndyRae added this to the v1.0.0 milestone Jan 28, 2025
@AndyRae AndyRae self-assigned this Jan 28, 2025
@AndyRae AndyRae moved this from Ready to Committed in Hutch Backlog Jan 28, 2025
@AndyRae AndyRae moved this from Committed to In Progress in Hutch Backlog Jan 31, 2025
@AndyRae AndyRae moved this from In Progress to Committed in Hutch Backlog Feb 3, 2025
@AndyRae AndyRae moved this from Committed to In Progress in Hutch Backlog Feb 5, 2025
@AndyRae AndyRae mentioned this issue Feb 15, 2025
3 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in Hutch Backlog Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant