Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quoting of DB objects should be the adapter's responsibility #52

Open
eculicny opened this issue Feb 24, 2021 · 0 comments
Open

Quoting of DB objects should be the adapter's responsibility #52

eculicny opened this issue Feb 24, 2021 · 0 comments
Labels
bug Something isn't working hygiene Clean-up and maintenance work that needs to be implemented

Comments

@eculicny
Copy link
Contributor

Why?

Any functionality that is specific to the external DB requirements should take place within the adapters. The Relation object should not handle quoting since that varies across DB flavors.

Also, the Relation.quoted function doesn't work. The all({val.isupper(), val.islower()}) located here will always return False

Who does this impact?

  • SnowShu will actually support quoting
  • Reducing the number of objects connected with external dependencies should make maintaining and contributing easier.
@eculicny eculicny added bug Something isn't working hygiene Clean-up and maintenance work that needs to be implemented labels Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hygiene Clean-up and maintenance work that needs to be implemented
Projects
None yet
Development

No branches or pull requests

1 participant