Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostgreslikeAdapter base class #7

Open
norton120 opened this issue Feb 26, 2020 · 0 comments
Open

PostgreslikeAdapter base class #7

norton120 opened this issue Feb 26, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@norton120
Copy link
Contributor

norton120 commented Feb 26, 2020

why?

source adapters need to be WAY more dry and intuitive before we ask for source contributions. this could largely be handled by creating a PostgreslikeAdapter base class that abstracts most of the statement logic to a common parent class.

who it will benefit?

Anyone looking to contribute a new source adapter class. Us, when we do any work on the existing snowflake adapter.

how you might implement it?

Migrate to a parent class for postgres-like implementations. these can be overridden on a statement level as needed, but often there will only need to be a handful of partials defined for a new adapter.

[Issue created by ethanknox: 2020-01-31]

@norton120 norton120 added the enhancement New feature or request label Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant