Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prep_data does not remove the ignored variables #1207

Open
AviralVijay-GSLab opened this issue Jul 30, 2018 · 0 comments
Open

prep_data does not remove the ignored variables #1207

AviralVijay-GSLab opened this issue Jul 30, 2018 · 0 comments

Comments

@AviralVijay-GSLab
Copy link

machine_learn function uses the prep_data function to prepare the data which is feed to the tune_model or flash model later. prep_data function have !!!dots or ignored variable which should not be included in model training, but prep_data gives the ignored columns also in the resultant dataset, on the other hand if one wants to use the same recipe then it removes the ignored columns.

Feature Requests

machine_learn function have impact of this issue because it directly provide the pd(i.e outcome of prep_data) to the tune_models or flash_models function, where ignored columns also be used in model training, that is controversial with the description provided in the model parameter and also with the applications of this function.

@michaellevy Please find the attached below screenshots and pdf document for more information.

Feature_Request.pdf

machine_learn 1

machine_learn 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant