Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment utility should take Storybook mode into account #62

Closed
dan1elhughes opened this issue Feb 21, 2018 · 2 comments
Closed

Environment utility should take Storybook mode into account #62

dan1elhughes opened this issue Feb 21, 2018 · 2 comments
Assignees
@peasandwell
Labels
🔺 Priority: High 🔧 Type: Tooling
Milestone
Berkswell release

Comments

@dan1elhughes
Copy link

Expected behaviour

The util/Environment singleton doesn't throw errors when running Storybook.

Actual behaviour

It throws errors because Storybook only passes in environment variables starting with STORYBOOK_ into the app.

Steps to reproduce behaviour

npm run storybook
@dan1elhughes dan1elhughes added this to the Berkswell release milestone Feb 21, 2018
@dan1elhughes dan1elhughes self-assigned this Feb 21, 2018
@peasandwell
Copy link
Contributor

It looks like this has been resolved on Storybook's side - storybookjs/storybook#2668

It's currently in a pre-release so I haven't been able to verify if this fixes the issue.

@ShaunBulbrook
Copy link
Member

@dan1elhughes can you offer any help with this.

@dan1elhughes dan1elhughes removed their assignment Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peasandwell peasandwell

Labels
🔺 Priority: High 🔧 Type: Tooling
Projects
None yet
Milestone
Berkswell release
Development

No branches or pull requests
3 participants
@peasandwell @ShaunBulbrook @dan1elhughes