NRE spam on compiling internal spaces

[JonnyOThan]

[EXC 13:11:07.644] NullReferenceException: Object reference not set to an instance of an object
    FlightGlobals.get_ActiveVessel () (at <4b449f2841f84227adfaad3149c8fdba>:0)
    Astrogator.AstrogatorMenu..ctor () (at <53d746b99efb4192a3e3b763aab2ce34>:0)
    UnityEngine.DebugLogHandler:LogException(Exception, Object)
    ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object)
    UnityEngine.Object:Instantiate(InternalProp)
    PartLoader:GetInternalProp(String)
    InternalModel:AddProp(ConfigNode)
    InternalModel:Load(ConfigNode)
    PartLoader:LoadInternalSpace(UrlConfig)
    <CompileInternalSpaces>d__79:MoveNext()
    KSPCommunityFixes.Performance.<FrameUnlockedCoroutine>d__62:MoveNext()
    KSPCommunityFixes.Performance.<PartLoader_CompileAll>d__58:MoveNext()
    UnityEngine.SetupCoroutine:InvokeMoveNext(IEnumerator, IntPtr)

KSP - 2024-02-24T132234.261.log.zip

[HebaruSan]

@JonnyOThan how do I reproduce this?

[JonnyOThan]

I’m pretty sure you just have RPM and an IVA with a MFD installed (e.g. DE_IVA)

[HebaruSan]

And KSPCommunityFixes presumably, since it's in the stack trace? Any others?

[JonnyOThan]

I doubt KSPCF is required, that’s just the fast loader patch.

[HebaruSan]

Hmm, does this exception actually happen without that mod?

[JonnyOThan]

Without KSPCF? I would be shocked if it didn't. KSPCF is calling the same stock loading methods but just in a different loop structure so that it doesn't get throttle by unity's coroutine logic.

[HebaruSan]

It looks like this property can throw an NRE if UnityEngine.Object.FindObjectOfType can't find a FlightGlobals object:

public class FlightGlobals : MonoBehaviour
{
	// ...
	public static FlightGlobals fetch
	{
		get
		{
			if (_fetch == null)
			{
				_fetch = (FlightGlobals)UnityEngine.Object.FindObjectOfType(typeof(FlightGlobals));
			}
			return _fetch;
		}
	}
	// ...
	public static Vessel ActiveVessel => fetch.activeVessel;

I have no idea when that might be possible. I guess I'll just slap on an "ignore NREs" wrapper.

[HebaruSan]

Re-opening because this probably wasn't actually fixed.