Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect behavior when dismissing "Personalized suggestions" confirmation dialog #413

Closed
src52 opened this issue Jan 12, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@src52
Copy link
Contributor

src52 commented Jan 12, 2024

Does it happen in OpenBoard, or is it exclusive to this modified version?
N/A.

Describe the bug
When disabling "Personalized suggestions", a confirmation dialog appears. Tapping a transparent area to dismiss the dialog is interpreted as pressing "OK", and personalized suggestions is disabled.

Every other instance of popup dialogs being closed in this way is interpreted as canceling, or not saving the changes made. (Keyboard height, hint source, popup key order)

To Reproduce

  1. Enable personalized suggestions.
  2. Tap the toggle to disable personalized suggestions.
  3. You'll receive a dialog warning you about data loss.
  4. Tap any area outside the dialog box to dismiss it.
  5. Notice that personalized suggestions is now toggled off.

Expected behavior
Personalized suggestions should only be disabled if the user taps "OK", all other instances should keep suggestions on.

App version
Latest as of January 12th 2024.

Device:
Pixel 6, Android 14.

@src52 src52 added the bug Something isn't working label Jan 12, 2024
@Helium314
Copy link
Owner

The problem behind this is that you can't actually cancel a change of the setting. The ok button here is the cancel button as in do nothing, while the cancel button does undo the setting change.

@Helium314 Helium314 added the contributor needed Feature needs a contributor in order to get implemented. Please ask if you're interested. label Jan 15, 2024
@Helium314 Helium314 removed the contributor needed Feature needs a contributor in order to get implemented. Please ask if you're interested. label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants