Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Issue with register_command: true and multiple commands defined in open_command: #166

Closed
NoltoxGit opened this issue Jan 12, 2025 · 3 comments

Comments

@NoltoxGit
Copy link

Hello,

I recently encountered an issue with the latest DevBuild of DeluxeMenus regarding the management of commands in the open_command section.

When multiple commands are defined in the open_command: section, some of them do not work correctly. This prevents players from using all the configured commands to open menus.
Among the defined commands, only the first one in the list displays the latest version of the menu. The other commands display an outdated version of the menu, from the last server restart.
This bug occurs only when the register_command: true option is enabled for a menu.

Steps to reproduce the bug:

  1. Define multiple commands in open_command: and enable the register_command: true option.
  2. Restart the server, modify the menu, and then execute /dm reload.
  3. Open the menu using the defined commands. Only the first command in the list displays the updated menu, while the others display an older version of this menu.

Expected behavior:
All listed commands should display the current menu, not an outdated version of this menu.

Additional information:

  • DeluxeMenus version: 1.14.1-DEV-PR--ee7573d0
  • Server version: Fork of Paper (1.21.3)
  • Configuration used:
open_command:
  - caisse
  - caisses
register_command: true
  • Video example:
    • The not outdated menu have dirt, bcs I open with /caisse command, so the first command defined.
    • The outdated menu doesn't have dirt, bcs I open with /caisses command, so the second command defined.
2025-01-12.01-11-44.mp4

Thank you in advance for your help!

@BlitzOffline
Copy link
Member

Thank you for the very detailed bug report. This issue has been known to us for a while but we were unable to find a fix for it so far.

I will link the duplicated issue here in hopes that we can get more attention to this issue and possibly find a fix: #3.

@NoltoxGit
Copy link
Author

NoltoxGit commented Jan 12, 2025

Thank you for the very detailed bug report. This issue has been known to us for a while but we were unable to find a fix for it so far.

I will link the duplicated issue here in hopes that we can get more attention to this issue and possibly find a fix: #3.

Hey @Kqliber and @BlitzOffline,
I can't download the devbuild that fixes the problem because the build has failed. Here is the link:

https://github.com/HelpChat/DeluxeMenus/actions/runs/12735223227/job/35493728658#step:6:108

@Kqliber
Copy link
Member

Kqliber commented Jan 14, 2025

later builds will now be available with a successful build
should be fixed in #167

@Kqliber Kqliber closed this as completed Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants