Skip to content
This repository has been archived by the owner on Dec 9, 2022. It is now read-only.

Fix the Hamburger Menu issue #65 #72

Merged

Conversation

aserputov
Copy link
Contributor

Feature:New Burger menu created with React.
Fixes: #65

@MidouWebDev

Copy link
Contributor

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like to add a screenshot of the previous and new? 🙂

Copy link
Contributor

@MidouWebDev MidouWebDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @aserputov, thanks for creating this PR.
You did a great job.
Can you look please at a small bug related to the X icon (to close the mobile menu), we can't see it on mobile devices and please can you make the mobile nav full page like what we have here : https://heptagram.xyz

Thank you so much.

@aserputov
Copy link
Contributor Author

@Panquesito7 yes. My bad.
Screen Shot 2021-10-25 at 4 04 43 PM
Screen Shot 2021-10-25 at 6 15 37 AM
Screen Shot 2021-10-25 at 4 04 52 PM

@aserputov
Copy link
Contributor Author

Hey, @MidouWebDev, I fixed that bug. If you will have any questions, just let me know:)

@MidouWebDev
Copy link
Contributor

Hey, @MidouWebDev, I fixed that bug. If you will have any questions, just let me know:)

I am going to check your last commit and let you know.
Thank you so much.

@MidouWebDev MidouWebDev self-requested a review October 25, 2021 20:14
Copy link
Contributor

@MidouWebDev MidouWebDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aserputov Great job, it is possible to close the mobile menu now.
But i noticed that this hamburger menu isn't full page, we can see the other content of the homepage like here in a tablet :

image

Same issue in a mobile device :

Screenshot_20211025-211720_Samsung Internet

Thank you so much.

@MidouWebDev MidouWebDev changed the title New feature for Header Burger Menu Fix the Hamburger Menu issue Oct 25, 2021
@MidouWebDev MidouWebDev changed the title Fix the Hamburger Menu issue Fix the Hamburger Menu issue #65 Oct 25, 2021
Fixed: full screen issue; disable scrolling in header, nav;
@MidouWebDev MidouWebDev self-requested a review October 25, 2021 20:53
Copy link
Contributor

@MidouWebDev MidouWebDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @aserputov !
Thank you so much for your contribution.

@MidouWebDev
Copy link
Contributor

@j-dogcoder This PR can be merged.
It closes #65

Copy link
Contributor

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@jaspermayone jaspermayone merged commit 65864c8 into jaspermayone-archive:react-switch-WIP Oct 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] Hamburger Menu not working in the REACT.JS website version
4 participants