-
Notifications
You must be signed in to change notification settings - Fork 9
Fix the Hamburger Menu issue #65 #72
Fix the Hamburger Menu issue #65 #72
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you like to add a screenshot of the previous and new? 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @aserputov, thanks for creating this PR.
You did a great job.
Can you look please at a small bug related to the X icon (to close the mobile menu), we can't see it on mobile devices and please can you make the mobile nav full page like what we have here : https://heptagram.xyz
Thank you so much.
@Panquesito7 yes. My bad. |
Hey, @MidouWebDev, I fixed that bug. If you will have any questions, just let me know:) |
I am going to check your last commit and let you know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aserputov Great job, it is possible to close the mobile menu now.
But i noticed that this hamburger menu isn't full page, we can see the other content of the homepage like here in a tablet :
Same issue in a mobile device :
Thank you so much.
Fixed: full screen issue; disable scrolling in header, nav;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @aserputov !
Thank you so much for your contribution.
@j-dogcoder This PR can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🚀
Feature:New Burger menu created with React.
Fixes: #65
@MidouWebDev