Monsters attack after death

[AcidMarco]

== Describe the bug ==
Monsters deal 1-2 attacks after death.

== To Reproduce ==
Steps to reproduce the behavior:

1. Hunt Grand Pecos or another mobs.
2. Kill the monster with high attack speed or high damage.
3. Move away from the monster and got hit or miss by a monster after its death.

== Expected behavior ==
Monster stops attacks after death.

== Video ==
Reproducing the issue in the video:
https://www.youtube.com/watch?v=iE-iAah5sa0

== System specs (please complete the following information): ==

• Hercules Version [v2023.05.10]
• Mode: [pre-renewal]
• Packet version: [20200715]

== Comments: ==
Seems the mobs which has long attack motion reproduce this issue more often.
It reproduces after the mob dies, loot drops and after the chat info, that the mob has been defeated.

[csnv]

After some testing, I think it's a client bug rather than the emulator's, related to some mob animations.

I tried copying succubus' settings into grand peco: same movement speed, attack delay, motion, etc. While these settings work completely fine under succubus, under grand peco it works as you described.

On a more technical note, the packet is sent on a relatively predictable manner for both cases. However, while the succubus displays the attack damage after its attack animation ends, I've noticed that the damage displayed for grand peco's attack is not displayed when the attack animation ends, it occurs aprox. one second after the animation stopped, almost two seconds later than when the packet was received.

Maybe, the error in this case is the client is applying the animation time delay twice (960 x 2) for displaying damage in this case.

[csnv]

Confirmed, it's not a bug. You can read how to fix this client side here https://github.com/csnv/act-parser/blob/master/docs/fix-attack-delay.md