You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
In a particular part of the skill code, in function skill_attack, dmg.flag is being compared with ATK_BLOCK which is a damage_lv type enum. dmg.flag is intended for use with the BF_* type enumerator.
To Reproduce
There's no need to reproduce behavior, the code is quite evident.
Expected behavior
Find out the real reason for that check and recorrect it to compare with BF_* type if intended or compare dmg.dmg_lv with the damage_lv type enumator.
The change of checking dmg.dmg_lv instead of dmg.flag is also intended because skill->additional_effect checks for the dmg.dmg_lv in the previous line of code. therefore leading to skill->counter_additional_effect when the function returns.
Screenshots
System specs (please complete the following information):
Describe the bug
In a particular part of the skill code, in function
skill_attack
,dmg.flag
is being compared withATK_BLOCK
which is adamage_lv
type enum.dmg.flag
is intended for use with theBF_*
type enumerator.To Reproduce
There's no need to reproduce behavior, the code is quite evident.
Expected behavior
Find out the real reason for that check and recorrect it to compare with BF_* type if intended or compare dmg.dmg_lv with the
damage_lv
type enumator.The change of checking
dmg.dmg_lv
instead ofdmg.flag
is also intended becauseskill->additional_effect
checks for thedmg.dmg_lv
in the previous line of code. therefore leading toskill->counter_additional_effect
when the function returns.Screenshots
System specs (please complete the following information):
Plugins used or source modifications
none
Additional context
the version i'm using is from 2019 so its pretty old but I doubt someone has checked the code.
The text was updated successfully, but these errors were encountered: