Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero zoom is possible, crashes script #16

Open
perey opened this issue Sep 1, 2016 · 2 comments
Open

Zero zoom is possible, crashes script #16

perey opened this issue Sep 1, 2016 · 2 comments

Comments

@perey
Copy link

perey commented Sep 1, 2016

Steps to reproduce

  1. Load page.
  2. Reduce zoom until it reads zero.
  3. Crash.

Firefox specifically reports this error:

A script on this page may be busy, or it may have stopped responding. You can stop the script now, open the script in the debugger, or let the script continue.

Script: http://hermann.is/gravity/js/gravity/modules/render.js:273

Expected behaviour

Form field does not allow setting zero zoom. Script enforces a minimum value on zoom, or else raises an error if given zero zoom.

@MuhsinFatih
Copy link
Contributor

Thanks for reporting.
@HermannBjorgvin after my commit with zoom it was fine. Problem should be in the latest commits. Expected behavior does not have to be disabling zero zoom.

@HermannBjorgvin
Copy link
Owner

Yes, currently working on a new GUI which combines both the render and gui module, should be much smoother and bug free when implemented. Having the seperate gui and render modules was just something I decided on after not sleeping for 24h and has since proven to be a bad idea and prone to frequent bugs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants