Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not very idiomatic go code #4

Open
jsimnz opened this issue Feb 28, 2014 · 0 comments
Open

Not very idiomatic go code #4

jsimnz opened this issue Feb 28, 2014 · 0 comments

Comments

@jsimnz
Copy link
Member

jsimnz commented Feb 28, 2014

No negatively, the code so far is awesome, however its not very idiomatic.

So far it's just a collection of functions. Idiomatic go code is very modular in its use of interfaces, structs, and attached methods, especially the encoding packages.

Take a look at some of the builtin encoding package (ie http://golang.org/pkg/encoding/gob).

No need for any drastic changes atm, functionality is the most important, but for the sake of maintainability and outside contributions we should look into a slight re-organization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants