Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.push and .cover interactive transitions start abruptly. #299

Closed
maxhuk opened this issue Oct 16, 2017 · 5 comments
Closed

.push and .cover interactive transitions start abruptly. #299

maxhuk opened this issue Oct 16, 2017 · 5 comments

Comments

@maxhuk
Copy link

maxhuk commented Oct 16, 2017

Instead of starting at the edge of the screen they start a bit off the edge. Issue happens only with interactive transitions (I was using a pan gesture recognizer).

simulator screen shot - iphone 6s plus - 2017-10-17 at 00 20 59

@lkzhao
Copy link
Collaborator

lkzhao commented Nov 22, 2017

I have to look into this. Did you use Hero.shared.apply(...) to control the interactive behaviour? or just Hero.shared.update?

@maxhuk
Copy link
Author

maxhuk commented Nov 22, 2017

@lkzhao Just update, I used exactly the same code that was in the example article on interactive transitions using Hero that you've wrote.

@lkzhao lkzhao closed this as completed Nov 22, 2017
@lkzhao lkzhao reopened this Nov 22, 2017
@lkzhao
Copy link
Collaborator

lkzhao commented Nov 22, 2017

Ok, let me look.

@lkzhao
Copy link
Collaborator

lkzhao commented Nov 22, 2017

Should be fixed in the latest master. I have added a left edge pan gesture recognizer to that screen that you showed.

@lkzhao lkzhao closed this as completed Nov 22, 2017
@maxhuk
Copy link
Author

maxhuk commented Nov 23, 2017

@lkzhao Just tried it and can confirm that it works now. Thank you for taking the time to make a fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants