-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash sometimes in this line #333
Comments
Thanks! fixed in the latest master. |
Awesome! |
That will be great! Actually I will have some time to take care of this repo from now on. What Hero needed the most is some nice tutorial/documentation to get started. As the framework author I don't know what are the parts that are confusing for new comers. If you can help writing some tutorial/documentation that will be awesome! You will definitely get acknowledged on the README. |
I would contribute more on the coding side, I am not the best tutorial person myself, also, you did fantastic with your tutorials, as a user, this is the best framework documentation I have seen. Developers don't read tutorials as you know :) |
https://github.com/lkzhao/Hero/blob/1c8c3e5804041115eea9d64d1f27ea919a909056/Sources/Animator/HeroCoreAnimationViewContext.swift#L220
Fix:-
if let fromSize = fromValue as? NSValue, let toSize = toValue as? NSValue {
The text was updated successfully, but these errors were encountered: