Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash sometimes in this line #333

Closed
imougy opened this issue Nov 20, 2017 · 4 comments
Closed

Crash sometimes in this line #333

imougy opened this issue Nov 20, 2017 · 4 comments

Comments

@imougy
Copy link
Contributor

imougy commented Nov 20, 2017

https://github.com/lkzhao/Hero/blob/1c8c3e5804041115eea9d64d1f27ea919a909056/Sources/Animator/HeroCoreAnimationViewContext.swift#L220

Fix:-
if let fromSize = fromValue as? NSValue, let toSize = toValue as? NSValue {

@lkzhao
Copy link
Collaborator

lkzhao commented Nov 22, 2017

Thanks! fixed in the latest master.

@lkzhao lkzhao closed this as completed Nov 22, 2017
@imougy
Copy link
Contributor Author

imougy commented Nov 22, 2017

Awesome!
I can contribute a bit to the project after you leave. You did a fantastic job.

@lkzhao
Copy link
Collaborator

lkzhao commented Nov 22, 2017

That will be great! Actually I will have some time to take care of this repo from now on. What Hero needed the most is some nice tutorial/documentation to get started. As the framework author I don't know what are the parts that are confusing for new comers. If you can help writing some tutorial/documentation that will be awesome! You will definitely get acknowledged on the README.

@imougy
Copy link
Contributor Author

imougy commented Nov 22, 2017

I would contribute more on the coding side, I am not the best tutorial person myself, also, you did fantastic with your tutorials, as a user, this is the best framework documentation I have seen. Developers don't read tutorials as you know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants