Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Mult Network #46

Open
8 tasks
rkdud007 opened this issue Mar 21, 2024 · 0 comments
Open
8 tasks

Support Mult Network #46

rkdud007 opened this issue Mar 21, 2024 · 0 comments
Labels
enhancement New feature or request P-middle Middle priority, for near future

Comments

@rkdud007
Copy link
Member

rkdud007 commented Mar 21, 2024

context

Current version is assuming on getting BlockSampledDataLake only Ethereum Sepolia network. However, in the future, as we planning on supporting other networks, we need to specify exact chain Id in BlockSampledDataLake field.

more, before hardfork of ethereum, there was no chain_id was introduced, so without passing chain_id would result unsound TransactionsInBlockDatalake

Here is following todos:

BlockSampledDatalake

  • (hdp-cli) add chain_id as field of BlockSampledDataLake struct.
pub struct BlockSampledDatalake {
    pub chain_id: u64,
    pub block_range_start: u64,
    pub block_range_end: u64,
    pub increment: u64,
    pub sampled_property: String,
}
  • (Cairo Program) add chain_id as field of BlockSampledDataLake struct.
  • (Contract) add chain_id as field of BlockSampledDataLake struct.
struct BlockSampledDatalake {
    uint256 chain_id;
    uint256 blockRangeStart;
    uint256 blockRangeEnd;
    uint256 increment;
    bytes sampledProperty;
}
  • (Server) add chain_id as field of BlockSampledDataLake struct.

TransactionsInBlockDatalake

  • (hdp-cli) add chain_id as field of TransactionsInBlockDatalake struct.
pub struct TransactionsInBlockDatalake {
    pub chain_id: u64,
    pub target_block: u64,
    pub sampled_property: TransactionsCollection,
    pub increment: u64,
}
  • (Cairo Program) add chain_id as field of TransactionsInBlockDatalake struct.
  • (Contract) add chain_id as field of TransactionsInBlockDatalake struct.
struct TransactionsInBlockDatalake {
    uint256 chain_id;
    uint256 target_block;
    uint256 increment;
    bytes sampledProperty;
}
  • (Server) add chain_id as field of TransactionsInBlockDatalake struct.

Test check

Make sure to have hash be same around all flow

@rkdud007 rkdud007 changed the title Support Multi chain Support Mult Network Mar 23, 2024
@rkdud007 rkdud007 added enhancement New feature or request P-middle Middle priority, for near future labels Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P-middle Middle priority, for near future
Projects
None yet
Development

No branches or pull requests

1 participant