Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links in sidebar are not working on Linux #968

Closed
CommandMC opened this issue Feb 10, 2022 · 2 comments
Closed

Links in sidebar are not working on Linux #968

CommandMC opened this issue Feb 10, 2022 · 2 comments

Comments

@CommandMC
Copy link
Collaborator

Describe the bug
When clicking the Kofi, Patreon, or Discord links in the sidebar, nothing actually opens

Add Logs
When a button is clicked, Check failed: chdir(current_directory) == 0 is printed out

To Reproduce
Steps to reproduce the behavior:

  1. Open Heroic
  2. Click any of the 3 links in the sidebar (Kofi, Patreon, Discord)

Expected behavior
Well, the link should open

Desktop (please complete the following information):

  • OS: Arch Linux, KDE Plasma. Not reproducible on Windows
  • Heroic Version [e.g. 22]: 2.1.1 (currently this is also the main version)
  • Game: N/A
  • Wine/Proton version: N/A
  • Hardware specs (RAM, CPU, GPU): N/A
@CommandMC CommandMC changed the title Links in sidebar are not working Links in sidebar are not working on Linux Feb 10, 2022
@imLinguin
Copy link
Member

imLinguin commented Feb 10, 2022

This is most likely due to change in https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/blob/main/electron/utils.ts#L262 . Probably we should check if path starts with http or https and run xdg-open or shell.openExternal

@flavioislima
Copy link
Member

Yes, probably. forgot to test all links when I changed that 🤦🏽‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants