You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Limitation when people specify a link externally (https://developers.cloudflare.com/workers/) that should really be evaluated (and flagged) as if they're internal links (/workers/).
This situation skips evaluation, as demonstrated in this test PR || CI run
Describe the solution you'd like
I'd love it if you were able to specify a host or at least a pattern to ignore so that these links would be evaluated as internal.
That way, we could accept the links and know that they were valid and then fix in the background gradually.
Interesting use case. I don't think it's something I've think about before.
My first question (and not trying to ditch the feature request, just my normal train of thought) is, if the link should be /workers/, shouldn't this be handled by another remark plugin running before the validation transforming https://developers.cloudflare.com/workers/ into /workers/, and maybe enabled by default and disabled (using an environment variable) during the linting for this run on a specific cadence?
I'll think about the request anyway, if it would be a good addition to the plugin and more specifically which form it should take.
Is your feature request related to a problem?
Limitation when people specify a link externally (
https://developers.cloudflare.com/workers/
) that should really be evaluated (and flagged) as if they're internal links (/workers/
).This situation skips evaluation, as demonstrated in this test PR || CI run
Describe the solution you'd like
I'd love it if you were able to specify a
host
or at least a pattern to ignore so that these links would be evaluated as internal.That way, we could accept the links and know that they were valid and then fix in the background gradually.
Describe alternatives you've considered
We have linting around this in PRs, but it does add friction for contributors.
https://github.com/cloudflare/cloudflare-docs/pull/19799/files#r1945066002
As long we can evaluate these links successfully, we'd love to just not even worry about this in reviews and fix these on a cadence.
Additional Context
No response
The text was updated successfully, but these errors were encountered: