Issue with naive vs FFT convolver test?

[marcel303]

Hi,

Shouldn't the line:
if (relError > relTolerance && absError > absTolerance)

Over here,

FFTConvolver/test/Test.cpp

Line 233 in f2cdeb0

if (relError > relTolerance && absError > absTolerance)

Read:
if (relError > relTolerance || absError > absTolerance)

Right now it fails if and only if both fail. Isn't it expected the test fails if either absolute or relative error exceeds the threshold? (so logical or should be used).

There is another similar test in the same file by the way.

Regards,
Marcel