Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR for multiple changes #6

Open
brunotvs opened this issue Jan 3, 2025 · 1 comment
Open

PR for multiple changes #6

brunotvs opened this issue Jan 3, 2025 · 1 comment

Comments

@brunotvs
Copy link
Contributor

brunotvs commented Jan 3, 2025

I have split that previous PR into smaller branches. How do you prefer the pull requests to be created? Should I submit one big PR with all the changes, or create smaller PRs and wait to see if they get merged individually?
@HiPhish
Copy link
Owner

HiPhish commented Jan 5, 2025

Multiple PRs are better, and each PR can contain multiple commits when appropriate. It is easier to audit this way and we can squash the commits before merging if it makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HiPhish @brunotvs