-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8*MLP was trained during finetune #3
Comments
Thanks for pointing it out, there might be some missing lines when migrating the code from server to public repo. We'll look into it and update code soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thanks for your excellent work, but it seems that when finetuning the model on a new domain data, the mapping net(8mlp) was not frozen, which conflicts with your papers, though requires_grad==False was set in L422-425 of train.py. The gradient is activated in L229 again and the G_optimizer optimize all parameters of G. When I print the parameters of 8MLP on the original model and finetuned, they indeed different.
The text was updated successfully, but these errors were encountered: