Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate what would be required to move to Laplacians #8

Open
jlperla opened this issue Oct 21, 2020 · 2 comments
Open

Investigate what would be required to move to Laplacians #8

jlperla opened this issue Oct 21, 2020 · 2 comments
Assignees

Comments

@jlperla
Copy link
Member

jlperla commented Oct 21, 2020

@ajozefiak It looks like the Laplacians repo is active again, and they have updated to the latest julia.

What would it take for us to upstream our changes (if they make sense) to that repo. The primary reason we wanted to do this was that there were too many dependencies in https://github.com/danspielman/Laplacians.jl/blob/master/Project.toml so we would want to try to get someat least Plots. But that could be a PR we constribute.

What were the other things you added or tweaked?

@ajozefiak
Copy link
Collaborator

The first part was removing a bunch of dependencies, as you have pointed out. The second was extending the new interface to allow the package to spit out a linear operator that we can use however we want as a preconditioner. The library originally did not allow us to extract the linear operator and instead had its own cg implementation.

@jlperla
Copy link
Member Author

jlperla commented Oct 26, 2020

@ajozefiak Why don't you start by submitting a PR to that repo moving the dependencies that are not central to the main operations of the repo into the test = ["Test"] or whatever section. In particular, Plots.

Lets see how that goes. If he is willing to mere a high quality PR on that, then we can try to get our other stuff added which splits out the linear operator. No need to actually add in all of our own CG stuff, of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants