-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
useReplicant doesn't support namespaces #1
Milestone
Comments
Easy and simple API would be accepting an object as second argument of You are more than welcome to make PRs 😄 |
Sounds great, thanks. I'll try to get that out to you today. |
tedkulp
added a commit
to tedkulp/use-nodecg
that referenced
this issue
Mar 10, 2019
Hoishin
pushed a commit
that referenced
this issue
Apr 23, 2019
Hoishin
pushed a commit
that referenced
this issue
Apr 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
nodecg.Replicant has a 2nd optional parameter for namespace. Unfortunately, the bundle I'm working with uses it exclusively. See: https://nodecg.com/NodeCG.html#Replicant
I did make a quick version of
useReplicantNS
as a workaround, but would rather get something into your main repository. I didn't know if maybe adding it to the options and taking it out if it exists is better for your API than making a whole new method.I'm willing to make and submit the change, but I didn't want to do extra work that you might want to do differently anyway.
Thanks. Great work so far!
The text was updated successfully, but these errors were encountered: