Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useReplicant doesn't support namespaces #1

Closed
tedkulp opened this issue Mar 8, 2019 · 2 comments · Fixed by #2
Closed

useReplicant doesn't support namespaces #1

tedkulp opened this issue Mar 8, 2019 · 2 comments · Fixed by #2
Milestone

Comments

@tedkulp
Copy link
Contributor

tedkulp commented Mar 8, 2019

nodecg.Replicant has a 2nd optional parameter for namespace. Unfortunately, the bundle I'm working with uses it exclusively. See: https://nodecg.com/NodeCG.html#Replicant

I did make a quick version of useReplicantNS as a workaround, but would rather get something into your main repository. I didn't know if maybe adding it to the options and taking it out if it exists is better for your API than making a whole new method.

I'm willing to make and submit the change, but I didn't want to do extra work that you might want to do differently anyway.

Thanks. Great work so far!

@Hoishin
Copy link
Member

Hoishin commented Mar 8, 2019

Easy and simple API would be accepting an object as second argument of useReplicant.
It could be the same API as original NodeCG one, but it would require function type overload and lots of type guard.
Having another hook is not ideal to me.

You are more than welcome to make PRs 😄

@tedkulp
Copy link
Contributor Author

tedkulp commented Mar 10, 2019

Sounds great, thanks. I'll try to get that out to you today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants