Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

informationUri not always populated by scanners (semgrep) #6

Closed
Gby56 opened this issue Jul 24, 2023 · 1 comment · Fixed by #7
Closed

informationUri not always populated by scanners (semgrep) #6

Gby56 opened this issue Jul 24, 2023 · 1 comment · Fixed by #7

Comments

@Gby56
Copy link

Gby56 commented Jul 24, 2023

https://github.com/HollowMan6/sarif4reviewdog/blob/70fd54da0c00b0e4b807de395cc60b42e34c5453/convert.py#L14C8-L14C8

Seems like that key in the dict doesn't exist for semgrep SARIF, so it can't be converted.
Could we put a default value "" or something configurable via the with inputs of the action maybe ?

@HollowMan6
Copy link
Owner

Should be fixed in https://github.com/HollowMan6/sarif4reviewdog/releases/tag/v1.0.1

Thanks for raising this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants