Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Architecture Request] arm64 docker image #34

Open
aozaki-kuro opened this issue Jul 19, 2023 · 2 comments
Open

[Architecture Request] arm64 docker image #34

aozaki-kuro opened this issue Jul 19, 2023 · 2 comments

Comments

@aozaki-kuro
Copy link

aozaki-kuro commented Jul 19, 2023

For the same reason as outlined in HoloArchivists/fc2-live-dl#45
But adding platforms: linux/amd64, linux/arm64 to the GitHub Actions workflow is insufficient.

I noticed numerous x86_64 targeted build processes within the Dockerfile and failed on local build.

cargo build --locked --release --target x86_64-unknown-linux-musl; \

cargo build --locked --release --target x86_64-unknown-linux-musl

/src/target/x86_64-unknown-linux-musl/release/hoshinova \

🥺

Edit: I forked the repo, replaced all x86_64 with aarch64 and successfully built it in own aarch64 server. But I have no idea how should the whole CI be modified (and seemed to be very slow per build).

@Cellularhacker
Copy link

@aozaki-kuro 👍🏼 It's a very good idea. As same as your test, if we need an arm64-based container image, we have to build it it on arm64 machine.

I used to use build them in parallel by OS & Architecture combination by using Github Actions with each combination.

@aozaki-kuro
Copy link
Author

As a follow-up, I have forked the repo, replaced the x86_64 with aarch64 and tried to build it on Github Actions.
The build completed successfully on my arm64 server, but it turned out to have some problems with yarn on Actions?

image

https://github.com/aozaki-kuro/hoshinova/actions/runs/5680895181/job/15395907750#step:6:784
The process probably need some more tweaks 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants