-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Manifest V3 #18
Comments
For investigating the changes of going from background pages to serviceworker, perhaps it's not a huge deal? Content-Script still works like normal, it's just the background script that becomes more like service worker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Google is killing content blockers by removing
webRequestBlocking
API from extensions using Manifest v3, and removing support for Manifest v2. This affects Holodex+, because we use that API.webRequestBlocking
can be replaced bydeclarativeNetRequest
videoId
,channelId
would have to be known before live chat loadsIf either of these turn out to be blockers for using mv3, then we'll have to maintain separate versions for Chrome/Chromium and non-Chromium browsers (e.g. Firefox).
Notes
We use
webRequestBlocking
for:Stripping headers to allow embedding of archive chat
Holodex-Plus/src/background/index.ts
Lines 33 to 41 in d9b4c60
Redirecting a fake embed chat link to embed archive chat - this is dynamic, so may end up being a problem.
Holodex-Plus/src/background/index.ts
Lines 9 to 31 in d9b4c60
The text was updated successfully, but these errors were encountered: