Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brew bundle dump needs updating for new mas list format #11257

Closed
2 tasks done
emilazy opened this issue Apr 27, 2021 · 1 comment
Closed
2 tasks done

brew bundle dump needs updating for new mas list format #11257

emilazy opened this issue Apr 27, 2021 · 1 comment
Labels
bug Reproducible Homebrew/brew bug outdated PR was locked due to age

Comments

@emilazy
Copy link

emilazy commented Apr 27, 2021

brew config output

HOMEBREW_VERSION: 3.1.3-107-g1157a97
ORIGIN: https://github.com/Homebrew/brew
HEAD: 1157a97d8be039db16e1c0bff5a48d372696c5a9
Last commit: 10 hours ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: d9a1a62c7400b4cc3610b9ee65bba71e7dd7e880
Core tap last commit: 28 minutes ago
Core tap branch: master
HOMEBREW_PREFIX: /usr/local
HOMEBREW_CASK_OPTS: []
HOMEBREW_EDITOR: kak
HOMEBREW_MAKE_JOBS: 16
Homebrew Ruby: 2.6.3 => /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby
CPU: 16-core 64-bit kabylake
Clang: 12.0 build 1205
Git: 2.30.1 => /Applications/Xcode.app/Contents/Developer/usr/bin/git
Curl: 7.64.1 => /usr/bin/curl
macOS: 11.3-x86_64
CLT: N/A
Xcode: 12.5

brew doctor output

Your system is ready to brew.

  • I ran brew update and am still able to reproduce my issue.
  • I have resolved all warnings from brew doctor and that did not fix my problem.

What were you trying to do (and why)?

As of mas-cli/mas#339, mas list gives a formatted list:

emily@yuyuko ~> mas list
1440147259  AdGuard for Safari       (1.9.13)
497799835   Xcode                    (12.5)
425424353   The Unarchiver           (4.3.1)

This confuses brew, which is expecting a format without all the whitespace padding and includes it in the brew bundle dump output. This will affect people who use brew's mas integration once a new mas release is cut, which will likely be soon as it fixes the unnecessary upgrade problems many people were having (indeed, I discovered this after building and installing the latest source from HEAD to fix this issue on my system).

What happened (include all command output)?

emily@yuyuko ~> brew bundle dump --file=- | rg '^mas'
mas "1Password 7             ", id: 1333542190
mas "AdGuard for Safari      ", id: 1440147259
mas "Affinity Photo          ", id: 824183456
…

What did you expect to happen?

mas "1Password 7", id: 1333542190
mas "AdGuard for Safari", id: 1440147259
mas "Affinity Photo", id: 824183456
…

Step-by-step reproduction instructions (by running brew commands)

# Install mas from git, e.g. with `brew install --HEAD` or cloning the repository and `script/install $prefix`
$ brew bundle dump
@emilazy emilazy added the bug Reproducible Homebrew/brew bug label Apr 27, 2021
@emilazy
Copy link
Author

emilazy commented Apr 27, 2021

Moving this to Homebrew/homebrew-bundle#952.

@emilazy emilazy closed this as completed Apr 27, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label May 28, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Reproducible Homebrew/brew bug outdated PR was locked due to age
Projects
None yet
Development

No branches or pull requests

1 participant