Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rubydoc.brew.sh workflow more like formulae.brew.sh #17379

Closed
1 task done
MikeMcQuaid opened this issue May 28, 2024 · 1 comment · Fixed by Homebrew/rubydoc.brew.sh#629
Closed
1 task done

Make rubydoc.brew.sh workflow more like formulae.brew.sh #17379

MikeMcQuaid opened this issue May 28, 2024 · 1 comment · Fixed by Homebrew/rubydoc.brew.sh#629
Labels
features New features help wanted We want help addressing this outdated PR was locked due to age

Comments

@MikeMcQuaid
Copy link
Member

Verification

Provide a detailed description of the proposed feature

Homebrew/rubydoc.brew.sh has a "Scheduled regeneration" GitHub Action which commits changes to the repository and pushes them. This is a bit like what Homebrew/formulae.brew.sh used to do, too.

Instead, it should make use of the GitHub Pages v4 deployment mechanism which doesn't require generated files to be committed.

This can also mean that PRs are required on this repository.

What is the motivation for the feature?

Enabling additional security features on Homebrew/rubydoc.brew.sh.

How will the feature be relevant to at least 90% of Homebrew users?

It won't be.

What alternatives to the feature have been considered?

(note: opening on Homebrew/brew for improved visibility)

@MikeMcQuaid
Copy link
Member Author

This was done, thanks @Rylan12!

@github-actions github-actions bot added the outdated PR was locked due to age label Jul 14, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
features New features help wanted We want help addressing this outdated PR was locked due to age
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant