Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uninstall symlink remains #4359

Closed
nickl- opened this issue May 13, 2014 · 2 comments
Closed

uninstall symlink remains #4359

nickl- opened this issue May 13, 2014 · 2 comments

Comments

@nickl-
Copy link
Contributor

nickl- commented May 13, 2014

I had a quick glance through the 301 issues returned from a search for uninstall and couldn't spot anything that appears related. I just want to make a quick note of this issue. Unfortunately this is as much as my availability allows at this point but should I find a gap I will gladly look into the problem some more.

Problem

Link remains in ~/Applications after uninstall for apps installed with empty link attribute.

Scenario

I created a new cask, which initially had no value specified for the link attribute and upon installation a link to the extracted archive folder, the version number of the app, in the caskroom was created for the app under ~/Application/{{version number}} instead of a link to the .app. After discovering the purpose of said link attribute I fixed the descriptor and proceeded to reinstall (uninstall + install) the app again.

The link to the extracted caskroom folder remained, was broken after uninstall but linked again after fresh installation. Uninstalling apps with their link attribute configured do get cleaned up appropriately with the symlink deleted from ~/Applications which leads me to believe the problem is related to the absence of a link attribute.

@rolandwalker
Copy link
Contributor

Hi!

If I understand your scenario, this relates to #3066.

The conceptual error in our code is that it tries to uninstall based on the latest Cask definition, rather than uninstalling based on the Cask definition which was active at the time you made the install. So there is no guarantee that it always knows how to undo what it has done.

@vitorgalvao
Copy link
Member

No longer relevant: #13201.

@miccal miccal removed bug Issue describing a reproducible bug. discussion labels Dec 23, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants