odin: added odin libraries for linux #182310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
autosquash
xakep8
changed the title
|
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
|
The solution is not to duplicate the block, but to figure out which parts should only be on macOS and make the rest unconditional. It also needs test adjustments so we know it works. |
github-actions
bot
added
the
automerge-skip
|
@SMillerDev Do I need to update the test? |
|
Yes, because without it there is no way to know if this works |
xakep8
force-pushed
the
odin_vendor_libraries_for_linux
branch
from
2848068
to
ad692a8
Compare
github-actions
bot
removed
the
automerge-skip
xakep8
force-pushed
the
odin_vendor_libraries_for_linux
branch
3 times, most recently
from
588ab6a
to
e68fa14
Compare
gromgit
reviewed
Aug 28, 2024
SMillerDev
reviewed
Aug 31, 2024
xakep8
force-pushed
the
odin_vendor_libraries_for_linux
branch
3 times, most recently
from
2f525c7
to
b912b6a
Compare
xakep8
force-pushed
the
odin_vendor_libraries_for_linux
branch
from
b912b6a
to
b24d467
Compare
|
@SMillerDev I have made the changes and as per @laytan the issue with the shared library is an upstream issue with odin, is there any more change required to the code? |
xakep8
force-pushed
the
odin_vendor_libraries_for_linux
branch
from
b24d467
to
6b05bb4
Compare
github-actions
bot
removed
the
autosquash
carlocab
reviewed
Sep 8, 2024
xakep8
force-pushed
the
odin_vendor_libraries_for_linux
branch
from
6b05bb4
to
a4821e5
Compare
carlocab
approved these changes
Sep 11, 2024
xakep8
force-pushed
the
odin_vendor_libraries_for_linux
branch
2 times, most recently
from
b74d29a
to
14dfa31
Compare
carlocab
reviewed
Sep 11, 2024
|
@carlocab I've made all the requested changes and I am pushing my new code in a bit kindly review that for any changes required. |
Linked back the vendor libraries for odin on linux. Use of shared library is still not working as it is an upstream issue. Closes Homebrew#182068 odin: added vendor deps and build from source for odin odin: changes .dylib to .so odin: fixed lint odin: fixed lint odin: attempted fixes for macos-arm64 odin: attempted fixes for macos-arm64 odin: attempted fixes for macos-arm64 odin: attempted fixes for macos-arm64 odin: added tests to verify it runs on linux odin: fixed tests for linux odin: fixed tests for linux Fixed all tests for linux. Closes Homebrew#182068 odin: fixed tests Fixed tests for linux. Closes Homebrew#182068 odin: fixes shared library on linux Closes Homebrew#182068 The tags during the building and linking phase where placed in the wrong way and the gcc compiler was not treating the linking of the shared objects as a shared library. Fixed them and all tests run perfectly. odin: changed the structure to if...else... block changed the structure of code as per review. odin: fixed all tests Closes Homebrew#182068 Fixed all tests. The shared library test fails because of issue with odin. odin: changed the code to make build steps unconditional odin: fixed styling issues. odin: made the requested changes. odin: fixed linting issues.
xakep8
force-pushed
the
odin_vendor_libraries_for_linux
branch
from
14dfa31
to
b13a6ef
Compare
|
🤖 An automated task has requested bottles to be published to this PR. |
github-actions
bot
added
the
CI-published-bottle-commits
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?Closes #182068
I've added the vendor libraries for linux and built them and also changed the test to verify it on linux.