Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL MacOS Mojave 10.4 black screen. #33016

Closed
6 tasks done
illume opened this issue Oct 16, 2018 · 14 comments
Closed
6 tasks done

SDL MacOS Mojave 10.4 black screen. #33016

illume opened this issue Oct 16, 2018 · 14 comments
Labels
outdated PR was locked due to age upstream issue An upstream issue report is needed

Comments

@illume
Copy link
Contributor

illume commented Oct 16, 2018

  • are reporting a bug others will be able to reproduce and not asking a question. If you're not sure or want to ask a question do so on our Discourse: https://discourse.brew.sh
  • have a problem with brew install (or upgrade, reinstall) a single, official formula (not cask)? If it's a general brew problem please file this issue at Homebrew/brew: https://github.com/Homebrew/brew/issues/new/choose. If it's a brew cask problem please file this issue at https://github.com/Homebrew/homebrew-cask/issues/new/choose. If it's a tap (e.g. Homebrew/homebrew-php) problem please file this issue at the tap.
  • ran brew update and can still reproduce the problem?
  • ran brew doctor, fixed all issues and can still reproduce the problem?
  • ran brew gist-logs <formula> (where <formula> is the name of the formula that failed) and included the output link?
  • if brew gist-logs didn't work: ran brew config and brew doctor and included their output with your issue?

To help us debug your issue please explain:

  • What you were trying to do (and why)
    Use SDL programs.
  • What happened (include command output)
    SDL programs show a black screen.
  • What you expected to happen
  • Step-by-step reproduction instructions (by running brew install commands)

Use an SDL program, and it will show a black screen.
See upstream bug reports and discussion.
https://bugzilla.libsdl.org/show_bug.cgi?id=4272
https://discourse.libsdl.org/t/macos-10-14-mojave-issues/25060

I'm not aware of a working patch at the time of writing.

@illume
Copy link
Contributor Author

illume commented Oct 16, 2018

Note, this effects SDL1 and SDL2.

@SMillerDev SMillerDev added the upstream issue An upstream issue report is needed label Oct 16, 2018
@fxcoudert
Copy link
Member

This appears to be a problem with the SDL projects, and not within Homebrew's configuration. Once a fix has been issued by upstream, we can integrated it into Homebrew (pul request welcome). That looks possible for SDL2, but SDL1 is long dead, so I am not sure how this can go there…

Many thanks for reporting the issue.

@illume
Copy link
Contributor Author

illume commented Oct 17, 2018

Yes, I'm following the issue closely and will submit a PR when a fix is available.

ps. I have a question about process around here... I think perhaps I'm confused, as other "upstream issue" breakages are left open. I thought linking to the upstream bug would be useful for people tracking to see if this has been fixed yet, and that it would reduce other people having to submit the same issue again. I know this is useful for people tracking the breakage, but if it's not something that this project wants then I won't link things up anymore. Is the difference "This appears to be a problem with the SDL projects, and not within Homebrew's configuration"? So I only submit issues that are to do with breakages if the issue is not in upstream?

pps. Probably a better word for SDL 1 is undead ;) There's an SDL 1 branch that collects fixes, and 'one' new release planned. There's more than 50k apps using SDL1... with users in the hundreds of millions(way more than homebrew).

@fxcoudert
Copy link
Member

As you say, we have to walk a fine line: we can't handle bug reports for all packages we ship, but we want to make sure a. they do not come from Homebrew packaging, b. they are reported upstream.

Basically, once a bug is identified, analysed, and reported upstream, there is not much we can do until it's fixed. Keeping all issues open would be a nightmare for us in terms of prioritising support. People can still find the issue if they search for it!

@illume
Copy link
Contributor Author

illume commented Oct 18, 2018

Makes sense. Thanks.

@Photosounder
Copy link

SDL 1.2 is actually still maintained (see https://hg.libsdl.org/SDL/shortlog/12354) but doesn't receive official releases anymore.

@Photosounder
Copy link

@illume SDL 2.0.9 has been released and fixes the problem apparently, but the formula for SDL2 still uses SDL 2.0.8 unfortunately.

@fxcoudert
Copy link
Member

@Photosounder 2.0.9 has introduced another bug: see #33578

@Photosounder
Copy link

Oh, that's rather concerning, but what's the bug? All this says is "Created with brew bump-formula-pr."

@fxcoudert
Copy link
Member

Sorry wrong PR: #33781

@Photosounder
Copy link

Thank you, I just filed a bug for this on the SDL bug tracker: https://bugzilla.libsdl.org/show_bug.cgi?id=4385

@illume
Copy link
Contributor Author

illume commented Nov 15, 2018

Here is the commit which fixes that issue: http://hg.libsdl.org/SDL/rev/d274fa9731b1
https://bugzilla.libsdl.org/show_bug.cgi?id=4367

I'm not sure when a new release is planned.

@Photosounder
Copy link

Yes sadly it doesn't seem like they intend on making a new release to fix this, so we might have to wait a few months until SDL 2.0.10.

@illume
Copy link
Contributor Author

illume commented Nov 15, 2018

I guess we could make a PR which is 2.0.9 with that patch?

@lock lock bot added the outdated PR was locked due to age label Dec 15, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Dec 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age upstream issue An upstream issue report is needed
Projects
None yet
Development

No branches or pull requests

4 participants