Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make require_root option not to require existence of run #636

Closed
Jerry1144 opened this issue Mar 17, 2024 · 2 comments
Closed

Make require_root option not to require existence of run #636

Jerry1144 opened this issue Mar 17, 2024 · 2 comments
Labels

Comments

@Jerry1144
Copy link

I find name+require_root perfect in "tool provides a system Daemon, and a ready-made plist to be put into /Library/LaunchDaemons" scenario. Like this service do:

service do
  name macos: "cc.chlc.batt"
  require_root true
end

It makes brew output the right command to run in the Caveats section, without the "or if you want to run it once, run [the run command]" latter half.

==> Caveats
To start batt now and restart at startup:
  sudo brew services start [formula]

Therefore I think the audit rules should allow require_root to exist with name and without run.

brew audit currently complains that run must be defined to use methods other than name like [:require_root]. If I removed the require_root line, I'd have to ask users to ignore the subsequent non-sudo brew services start in Caveats. How weird would that sound!

@SMillerDev
Copy link
Member

This repository has no control over brew audit. This should be moved to Homebrew/brew

@MikeMcQuaid
Copy link
Member

Closing in favour of Homebrew/brew#16908

@MikeMcQuaid MikeMcQuaid closed this as not planned Won't fix, can't repro, duplicate, stale Mar 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants