Skip to content
This repository has been archived by the owner on Jan 16, 2025. It is now read-only.

nimrod-lang: New and improved formulas #34693

Closed
wants to merge 12 commits into from
Closed

nimrod-lang: New and improved formulas #34693

wants to merge 12 commits into from

Conversation

philip-wernersbach
Copy link
Contributor

This pull request attempts to improve Homebrew's support for the Nimrod language by supplying two new and improved formulas. The explanation for the changes are in the commits themselves, and I'd also be happy to answer any questions about this here.

The new formula installs nimrod completely from source, following
the instructions from the readme.md in Araq/Nimrod. This method
does not rely on having a proper bootstrap stage supplied by
upstream, so theoretically this allows nimrod to be compiled
on any Homebrew setup.

The new formula also installs the 0.9.6 version of nimrod, and
attempts to stay as close to the upstream source installation
instructions as possible.
@DomT4
Copy link
Contributor

DomT4 commented Dec 5, 2014

One of the maintainers will be by to comment more substantially at some point in the next few hours, but Homebrew ❤️ double quotes everywhere.

@mistydemeo
Copy link
Contributor

@BrewTestBot test this please

require "formula"

class Nimble < Formula
homepage 'https://github.com/nimrod-code/nimble'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use double-quotes everywhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

end

test do
system "#{bin}/nimble", "--version"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bug in upstream. I filed a pull request at nim-lang/nimble#73

@philip-wernersbach
Copy link
Contributor Author

I'm going to start an upstream RFC for this so that we can develop a plan for handling how this deviates from upstream. I'll report back when I have more information.

@philip-wernersbach
Copy link
Contributor Author

The results of the upstream RFC are that we're going to keep nimble away from Homebrew right now and the nimrod formula is going to use the installation method based on the upstream bootstrap. I'll create a new pull request for nimrod only.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants