Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Node 0.12.3 #39780

Closed
DomT4 opened this issue May 15, 2015 · 2 comments
Closed

Node 0.12.3 #39780

DomT4 opened this issue May 15, 2015 · 2 comments

Comments

@DomT4
Copy link
Member

DomT4 commented May 15, 2015

It'll end up being submitted as a PR at some point if I don't stick this here. There's a new Node out, 0.12.3, but it contains an undeclared breaking change to v8.

I've been holding off teeing up a PR whilst waiting to see what the Node team do, whether there'll be a quick fix/release, etc. They've stuck a high priority on the issue and are moving quickly on it.

General request that we don't merge the new Node version until upstream have a fix for the breakage. It seems likely that if we merge it sans fix we'll end up getting hit with Node issues that aren't actually Homebrew's issues and we'll have to revert.

References:

@DomT4 DomT4 mentioned this issue May 16, 2015
@jrnewell
Copy link
Contributor

It looks like 0.12.4 is out with the breakage fix.

@DomT4
Copy link
Member Author

DomT4 commented May 23, 2015

Aye, they merged the V8 fix last night 🎉. There's a PR pending in #39825 for the previous version, I've asked the owner of that PR to rebase and rebump.

@DomT4 DomT4 closed this as completed May 23, 2015
@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants