-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
docker-machine-nfs 0.2.0 (new formula) #49920
Conversation
b4dc344
to
3d1de5d
Compare
|
||
def install | ||
mv "docker-machine-nfs.sh", "docker-machine-nfs" | ||
bin.install "docker-machine-nfs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can merge both lines into bin.install "docker-machine-nfs.sh" => "docker-machine-nfs"
.
@bfontaine thanks for the feedback, i've made the changes you requested. |
Initial commit of docker-machine-nfs; this is a script that eases the process of enabling NFS sharing (instead of the default VirtualBox) for boot2docker-based Docker VMs.
* single invocation of `bin.install` * download tarball instead of raw file
Upstream maintainer released a new version to comply with Homebrew's packaging requirements :)
d5d27a5
to
7dd0850
Compare
i'm happy to squash down these commits if you'd prefer. |
end | ||
|
||
test do | ||
system "#{bin}/docker-machine-nfs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can’t we write a test that does something more substantial than just printing the help?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bfontaine the script doesn't have a no-op mode, so any testing would involve making changes to the user's system. would printing the help and checking to make sure that a particular string matches the output be preferable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Let’s leave it as is then.
Thank you for your contribution to Homebrew, @hakamadare; we appreciate it! 🎉 |
Closes Homebrew/legacy-homebrew#49920. Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
Initial commit of docker-machine-nfs; this is a script that eases the
process of enabling NFS sharing (instead of the default VirtualBox) for
boot2docker-based Docker VMs.