graphql: return error if block from>to (ethereum#28393)

jsvisa · devopsbo3 · commit c637c84fc430 · 2023-11-10T11:09:46.000-06:00
As per discussion in ethereum/execution-apis#475
diff --git a/graphql/graphql.go b/graphql/graphql.go
@@ -41,7 +41,8 @@ import (
 )
 
 var (
-	errBlockInvariant = errors.New("block objects must be instantiated with at least one of num or hash")
+	errBlockInvariant    = errors.New("block objects must be instantiated with at least one of num or hash")
+	errInvalidBlockRange = errors.New("invalid from and to block combination: from > to")
 )
 
 type Long int64
@@ -1333,7 +1334,7 @@ func (r *Resolver) Blocks(ctx context.Context, args struct {
 		to = rpc.BlockNumber(r.backend.CurrentBlock().Number.Int64())
 	}
 	if to < from {
-		return []*Block{}, nil
+		return nil, errInvalidBlockRange
 	}
 	var ret []*Block
 	for i := from; i <= to; i++ {

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,8 @@ import (`
`41`	`41`	`)`
`42`	`42`
`43`	`43`	`var (`
`44`		`- errBlockInvariant = errors.New("block objects must be instantiated with at least one of num or hash")`
	`44`	`+ errBlockInvariant = errors.New("block objects must be instantiated with at least one of num or hash")`
	`45`	`+ errInvalidBlockRange = errors.New("invalid from and to block combination: from > to")`
`45`	`46`	`)`
`46`	`47`
`47`	`48`	`type Long int64`
`@@ -1333,7 +1334,7 @@ func (r *Resolver) Blocks(ctx context.Context, args struct {`
`1333`	`1334`	`to = rpc.BlockNumber(r.backend.CurrentBlock().Number.Int64())`
`1334`	`1335`	`}`
`1335`	`1336`	`if to < from {`
`1336`		`- return []*Block{}, nil`
	`1337`	`+ return nil, errInvalidBlockRange`
`1337`	`1338`	`}`
`1338`	`1339`	`var ret []*Block`
`1339`	`1340`	`for i := from; i <= to; i++ {`