Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do not reset cached anchor/feature to None in a new clip #74

Open
zhui064 opened this issue Jul 21, 2024 · 1 comment
Open

Why do not reset cached anchor/feature to None in a new clip #74

zhui064 opened this issue Jul 21, 2024 · 1 comment

Comments

@zhui064
Copy link

zhui064 commented Jul 21, 2024

In instance_bank.py, the function reset is only called at the first time entering the function get. But for a new clip, cached anchor/feature is not reset to None. Instead, cached anchor/feature of last clip is used. It maybe a bug but almost no impact on effect ?

@linxuewu
Copy link
Collaborator

Yes, this is a bug, but it doesn't affect the outcome significantly.

The correct approach is to use instance_bank.mask for new clips, setting the temporal anchor and feature as the current anchor and feature in the temporal cross attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants