-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix(care plan): fix view button label in list #2376
Conversation
@gaweki looks like the build is failing. Also, you'll need to sign the CLA. |
how to sign the CLA, mr @jackcmeyer ? and how to fix the build? |
To sign CLA: click the hyperlinks in the comment: #2376 (comment). To fix build, run |
@@ -4,6 +4,7 @@ export default { | |||
filterTitle: 'Filter by status', | |||
search: 'Search labs', | |||
successfullyUpdated: 'Successfully updated', | |||
successfullyCompleted: 'Succesfully Completed', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe @jackcmeyer wanted this to be Successfully completed ${type} for ${patient}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should i add 'for' text? Cause the original text must be ${t('labs.successfullyCompleted')} ${complete.type} ${patient?.fullName}
@morrme @jackcmeyer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep Pull Requests as atomic units, I think we should move the fixing of the lab success message to a different pull request.
i make PR from different branch and start from latest commit on master branch original repo? |
already reset commits. another commit is on another PR @jackcmeyer |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/2v11mvzov |
Fixes #2372
Changes proposed in this pull request:
Newly added dependencies with Bundlephobia links:
NONE